Open
Conversation
Signed-off-by: Rafael Zago <[email protected]>
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR aims to fix the PFX error that occurs when running the makelogs application. It does so by implementing a javascript instruction
ssl:{ rejectUnauthorized: false, pfx: [] }that bypasses the error and allows the application to run smoothly.Why is this change necessary?
Currently, when running the makelogs application, some users are facing a PFX error that prevents them from using the application as intended. This change addresses this issue by bypassing the error, and making the application accessible to all users.
How has this change been tested?
This change has been tested by running the makelogs application with the new instruction in place and confirming that the PFX error is no longer present. Additionally, the application was tested to ensure that it runs smoothly and no other issues have been encountered.
What are the relevant issue numbers?
This PR is related to issue #53
Screenshots (if appropriate)
N/A
Notes for reviewers
Please review the code changes and ensure that they are implemented correctly and do not cause any other issues. Additionally, please test the application with the new instruction in place to ensure that the PFX error is successfully bypassed.
Types of changes
Checklist
Please let me know if you have any questions or concerns.
Ref: https://www.gooksu.com/2022/01/generate-test-data-using-elastics-makelogs/
Signed-off-by: Rafael Zago [email protected]