feat: Add kakao auth button #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
elbeicktalat
requested changes
Aug 3, 2024
| @override | ||
| Color? getProgressIndicatorColor() { | ||
| if (style.buttonType == AuthButtonType.secondary) return AuthColors.kakao; | ||
| return Colors.yellow[200]; |
There was a problem hiding this comment.
Not sure if yellow[200] will be visible on kakao color sice it's also a yallow.
Use black color instead yellow since the icon and text are black.
There was a problem hiding this comment.
You did not provide a screenshot example of secondary icon.
Pls add 3 more screenshots in the conversation:
- default -> secondary
- outlined -> secondary
- icon -> secondary
I'm not happy with this icon as secondary, but we'll see if its look fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement
#62