feat(nsis): terminate only processes running in installation folder

[panther7]

Modified the process termination logic in NSIS scripts to only kill application processes that are running from the installation directory. This prevents accidental termination of processes with the same name running from other locations during installation or update.

issue: #9009

EDIT: Actually works only on PowerShell Core (7+), because (default) powershell 5.1 is broken, because Get-Process returns empty Path for processes. #9069 (comment)

[changeset-bot]

🦋 Changeset detected

Latest commit: d82b90a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages

Name	Type
app-builder-lib	Patch
dmg-builder	Patch
electron-builder-squirrel-windows	Patch
electron-builder	Patch
electron-forge-maker-appimage	Patch
electron-forge-maker-nsis-web	Patch
electron-forge-maker-nsis	Patch
electron-forge-maker-snap	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[mmaietta]

@beyondkmp would you mind taking a look at this when you have a chance?

[mmaietta]

@panther7 following up here, what tests have you run so far?

Wondering if we can create an install+update test somehow for this in GHA runner? Similar to how this works: https://github.com/electron-userland/electron-builder/pull/9113/files?diff=unified&w=1#diff-1d9441830c74b56db3ecc46ef9805c4519141c15e145fabb24159d86e49d526dR10-R31

[mmaietta]

Working on a full "blackbox" test suite for verifying installation and updater flows with native/non-mocked Updaters
#9122

Will get that functional and then pull it into this PR for you so that we can add a black-box test for this

[panther7]

After hard testing, done.

BUT, only works on powershell 7+, because powershell 5 have "bug" and sometimes are Paths empty, which I need for detect right process.

Anyway, taskkill and tasklist are fallback.

[panther7]

I found solution for PowerShell 5+. It must be use Get-CimInstance -ClassName Win32_Process, because Get-Process inside instance 32bit PowerShell 5 don't view Paths for 64bit application. Get-CimInstance returns Paths for all processes, both 32bit and 64bit.

Check fixup.

[mmaietta]

Nice work @panther7 !! I need to do some hard testing on my side just to sanity check. Is there a way to force whether powershell or cmd approach is used for app termination?

Just disable powershell via policy?

[panther7]

@mmaietta You can edit this to StrCpy $PowerShellPath "blablablaexe" if you want "disable" powershell.