Skip to content
This repository was archived by the owner on Oct 2, 2020. It is now read-only.

Fix sass imports - #75

Open
alexstrat wants to merge 10 commits into
electron-userland:masterfrom
getstation:fix/sass-imports
Open

Fix sass imports#75
alexstrat wants to merge 10 commits into
electron-userland:masterfrom
getstation:fix/sass-imports

Conversation

@alexstrat

@alexstrat alexstrat commented Jun 16, 2017

Copy link
Copy Markdown

Those 2 fixes worked on my project.

@alexstrat alexstrat changed the title Attempt to fix sass imports Fix sass imports Jun 16, 2017
@alexstrat

Copy link
Copy Markdown
Author

@paulcbetts @saschagehlich do you think you could review these changes?

@saschagehlich

Copy link
Copy Markdown
Contributor

Sorry man, I'm not responsible for this repository. :(

@alreece45

Copy link
Copy Markdown

@alexstrat I'm not a contributor here, the paths fix is simple enough, but the second change doesn't seem as obvious to me. Is the current code removing /sass/ from the path, even when it isn't supposed to?

It may be beneficial to have that as a separate request-- but I'm not responsible for this repository, either.

@Tenrys

Tenrys commented May 25, 2018

Copy link
Copy Markdown

This should fix nested imports, right?
Trying to load the entirety of bulma gets pretty broken right now, file paths seem broken.
@import "node_modules/bulma/bulma" works, @import "sass/utilities/_all" inside of the file doesn't, seemingly because of resolved path issue.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants