Skip to content

fix(search): improve project root path detection logic #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

beyondkmp
Copy link

@beyondkmp beyondkmp commented Apr 6, 2025

My project structure is as follows:

/User/test/project/app/

There is a yarn.lock file under /User/test, and a pnpm-lock.yaml file under project. The project root directory I want to obtain is /User/test/Project, but what is returned is /User/test.

We need to search for all three, and then return the longest one.

@beyondkmp beyondkmp requested a review from a team as a code owner April 6, 2025 01:55
Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you address the lint failures?

Copy link
Member

@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add additional test coverage for this use case?

@beyondkmp
Copy link
Author

Yes. UT is added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants