Skip to content

feat: add link to full commit log on comparison page #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jw409 wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −1
Open

feat: add link to full commit log on comparison page #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion app/routes/release/compare.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import { getGitHubReleaseNotes } from '~/data/github-data';
import { getAllVersionsInMajor, getReleaseForVersion, VersionFilter } from '~/data/release-data';
import { groupReleaseNotes, renderGroupedReleaseNotes } from '~/data/markdown';
import { textPlainResponse, wantsTextPlain } from '~/helpers/request';
import { ArrowDown, ArrowRight } from 'lucide-react';
import { ArrowDown, ArrowRight, ExternalLink } from 'lucide-react';
import { VersionInfo } from '~/components/VersionInfo';
import { useCallback } from 'react';
import { VersionTimeline } from '~/components/VersionTimeline';
Expand Down Expand Up @@ -268,6 +268,17 @@ export default function CompareReleases() {
<Link to={`/release/${fromVersion}`}>{fromVersion}</Link>
</span>
</div>
<div className="text-center mt-2">
<a
href={`https://github.com/electron/electron/compare/${fromVersion}...${toVersion}`}
target="_blank"
rel="noopener noreferrer"
className="inline-flex items-center gap-1 text-xs text-blue-600 dark:text-blue-400 hover:underline"
>
View full commit log on GitHub
<ExternalLink className="w-3 h-3" />
</a>
</div>
</div>

<div className="space-y-8">
Expand Down
Loading