Harden ROUND-CHANGE quorum checks with distinct signer verification#50
Open
chrischarlesharrison wants to merge 1 commit intomasterfrom
Open
Harden ROUND-CHANGE quorum checks with distinct signer verification#50chrischarlesharrison wants to merge 1 commit intomasterfrom
chrischarlesharrison wants to merge 1 commit intomasterfrom
Conversation
Extend the distinct signer validation pattern from PREPARE messages to ROUND-CHANGE messages, ensuring consistent enforcement across all consensus justification paths. Updates three functions: - hasQuorumOfRoundChangeMessagesForNil: dedup + validator set check - hasQuorumOfRoundChangeMessagesForPreparedRoundAndBlock: same - hasBadProposalCount loop in isJustified: dedup by signer address Also adds a length cap rejecting RC sets larger than the validator set.
chrischarlesharrison
force-pushed
the
round-change-quorum-checks
branch
from
6554684 to
61f190e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the distinct signer validation pattern from PREPARE messages to ROUND-CHANGE messages, ensuring proper enforcement across all consensus justification paths.