Semaine type : nouvelle entité PeriodPositionFreeLog pour stocker l'historique des créneaux fixes #840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
commented
May 4, 2023
| * @ORM\ManyToOne(targetEntity="PeriodPosition", cascade={"remove"}) | ||
| * @ORM\JoinColumn(referencedColumnName="id", onDelete="CASCADE") | ||
| */ | ||
| private $periodPosition; |
There was a problem hiding this comment.
je me pose la question si c'est une bonne idée de faire une relation ici, vs stocker un string. si la periodPosition change (par exemple on change l'horaire du créneau, ou pire on la supprime), alors on perd l'info...
There was a problem hiding this comment.
j'ai opté pour rajouter un champ supplémentaire "periodPositionString" : 2942501
raphodn
changed the title
raphodn
force-pushed
the
raphodn/period-position-free-log-entity
branch
from
2942501 to
9e5f612
Compare
petitalb
approved these changes
May 12, 2023
raphodn
force-pushed
the
raphodn/period-position-free-log-entity
branch
from
9e5f612 to
e344e0e
Compare
raphodn
force-pushed
the
raphodn/period-position-free-log-entity
branch
from
53ca356 to
63b06cf
Compare
raphodn
added a commit
that referenced
this pull request
May 15, 2023
This was referenced May 15, 2023
2 tasks
2 tasks
OursDesCavernes
pushed a commit
to Les400Coop/gestion-compte
that referenced
this pull request
Jan 20, 2024
…istorique des créneaux fixes (elefan-grenoble#840) * New entity PeriodPositionFreeLog * PeriodPositionFreeForm * Dispatch PeriodPositionFreedEvent * Add PeriodPositionFreeLogController with listAction * Add PeriodPositionFreeLog.bookedTime field * Add PeriodPositionFreeLog.periodPositionString field * Fixes
OursDesCavernes
pushed a commit
to Les400Coop/gestion-compte
that referenced
this pull request
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quoi ?
Calquer le fonctionnement de
ShiftFreeLog, mais ici pour les postes types des créneaux fixes.PeriodPositionFreeLogPeriodPositionFreedEventlorsque un poste type est libéréPeriodPositionFreeLogControllerqui affiche la liste de tous les postes types libérés (ordonné par plus récent + filtre basique)Reste à faire (autre PR) :
use_fly_and_fixed?Pourquoi ?
Pour garder un historique des postes types
Captures d'écran