Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash the build when trying to docker-package from a shallow clone of a commit #28503

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

HarHarLinks
Copy link
Contributor

@HarHarLinks HarHarLinks commented Nov 20, 2024

wearing a Nordeck hat - I hope the source branch is sufficient to auth that fact.

Pending clarification how to handle CLA between Nordeck and Element.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@HarHarLinks HarHarLinks requested a review from a team as a code owner November 20, 2024 15:52
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane

@florianduros florianduros removed their request for review December 24, 2024 14:48
@richvdh
Copy link
Member

richvdh commented Jan 30, 2025

Hi @HarHarLinks,

Pending clarification how to handle CLA between Nordeck and Element.

Any progress on getting that clarification?

@HarHarLinks
Copy link
Contributor Author

@neilisfragile is on it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants