ElementCall: Use ViewRoom dispatch action instead of react hoos to trigger call creation.
#29195
+51
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toger5
force-pushed
the
toger5/fix-call-handling-with-strict-mode
branch
from
820d813 to
b62cfca
Compare
toger5
force-pushed
the
toger5/fix-call-handling-with-strict-mode
branch
from
56023ec to
e07e7ba
Compare
toger5
changed the title
ViewRoom dispatch action instead of react hoos to trigger call creation.
In strict mode there is a call create -> destroy -> create infinite loop wen pressing the call button. This loop was a consequence of relying on component creation/destruction to handle creating and removing the call. This logic: - destroying a call if it was in the lobby but leaving it if it is connected when the user stops viewing the room the call belongs to. - Creating an ElementCall if there is not yet once when the user starts viewing a call. Belongs into the roomViewStore and not the components that are just a sideffect in the call livecycle. (view model separation)
toger5
force-pushed
the
toger5/fix-call-handling-with-strict-mode
branch
from
656057d to
2135918
Compare
src/stores/RoomViewStore.tsx
Outdated
Comment on lines
358
to
365
| const currentRoomCall = this.state.roomId ? CallStore.instance.getCall(this.state.roomId) : null; | ||
| if (payload.view_call && room) { | ||
| if (!currentRoomCall) { | ||
| ElementCall.create(room, false); | ||
| } | ||
| } | ||
| // Destroy the call when leaving call view | ||
| const prevRoomCall = this.state.roomId ? CallStore.instance.getCall(this.state.roomId) : null; |
There was a problem hiding this comment.
CallStore.instance.getCall(this.state.roomId) is retuning a different call on line 358 & 365 ?
Co-authored-by: Florian D <[email protected]>
|
We discussed this more internally and we will fix this in another planned refactor/feature eventually so I put this back into draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #29196
In strict mode there is a call create -> destroy -> create infinite loop wen pressing the call button.
This loop was a consequence of relying on component creation/destruction to handle creating and removing the call.
This logic:
Belongs into the roomViewStore and not the components that are just a sideffect in the call livecycle. (view model separation)
One could argue that starting a call should not begin with dispatching a view call action to the roomViewStore but the dispatch should happen based on some intend but this PR wants to be a fix for the infinite loop in Strict mode and not a call livecycle refactor.
Checklist
public/exportedsymbols have accurate TSDoc documentation.