Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new verification section to user profile #29200

Merged
merged 14 commits into from
Feb 10, 2025
Merged

Add new verification section to user profile #29200

merged 14 commits into from
Feb 10, 2025

Conversation

MidhunSureshR
Copy link
Member

@MidhunSureshR MidhunSureshR commented Feb 5, 2025 •
edited
Loading

Designs: https://www.figma.com/design/gpxHFDTNK796n84r1ZxYG2/Room-Header-%26-Details-(2024)?node-id=2199-25594&p=f&t=AV6ACs6jBxxhyB9r-0

  • Removes E2EIcon that was previously shown along with the display name.
  • Removes security section in the user profile including the device list.
  • Adds a new VerificationSection as per design except for the verify again/ withdraw verification part.
  • Some playwright tests unrelated to user profiles used to rely on the e2e icon that this PR removes. I've updated those tests to use the crypto API directly.

@MidhunSureshR MidhunSureshR changed the title More user profile changes Add new verification section to user profile Feb 5, 2025
@MidhunSureshR MidhunSureshR force-pushed the midhun/profile-changes/new-verification-section branch from 939501a to a696745 Compare February 5, 2025 18:07
MidhunSureshR
MidhunSureshR commented Feb 6, 2025
View reviewed changes
test/unit-tests/components/structures/TabbedView-test.tsx
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

common|security isn't used in the app anymore and was removed by yarn i18n. Have updated this test to use a different translation key.

@MidhunSureshR MidhunSureshR marked this pull request as ready for review February 6, 2025 11:34
@MidhunSureshR MidhunSureshR requested a review from a team as a code owner February 6, 2025 11:34
@MidhunSureshR MidhunSureshR requested a review from dbkr February 6, 2025 11:34
@MidhunSureshR MidhunSureshR requested a review from t3chguy February 6, 2025 11:34
@DoM1niC
Copy link

DoM1niC commented Feb 6, 2025

image
needs some style fixes with longer words like german

@MidhunSureshR MidhunSureshR force-pushed the midhun/profile-changes/new-verification-section branch from df3b3d3 to 833feff Compare February 9, 2025 16:40
@MidhunSureshR MidhunSureshR force-pushed the midhun/profile-changes/new-verification-section branch from 833feff to ac657e7 Compare February 9, 2025 16:40
@MidhunSureshR MidhunSureshR added this pull request to the merge queue Feb 10, 2025
Merged via the queue into develop with commit 52b42c0 Feb 10, 2025
31 checks passed
@MidhunSureshR MidhunSureshR deleted the midhun/profile-changes/new-verification-section branch February 10, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbkr dbkr dbkr approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from element-hq/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MidhunSureshR @DoM1niC @dbkr