Fix Japanese IME input handling in message composer #30324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses input issues with Japanese IME (Input Method Editor) where pressing Enter to confirm IME suggestions would create unwanted line breaks instead of properly confirming the input. Changes include: - Enhanced platform detection for proper cross-platform IME support - Improved composition event handling for Japanese input - Strengthened isComposing() method with platform-specific checks - Added proper handling for composition confirmation events - Platform-specific timing adjustments for input processing Fixes IME input issues on: - macOS Safari - Windows/Electron environments - Other modern browsers 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
|
|
github-actions
bot
added
the
Z-Community-PR
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
florianduros
requested changes
Jul 16, 2025
Comment on lines
+157
to
+168
| private detectPlatform(): IPlatformInfo { | ||
| const ua = navigator.userAgent.toLowerCase(); | ||
| const platform = navigator.platform || ""; | ||
|
|
||
| return { | ||
| isElectron: !!(window as any).electron || ua.includes('electron'), | ||
| isWindows: ua.includes('win') || platform.includes('Win'), | ||
| isMac: ua.includes('mac') || platform.includes('Mac'), | ||
| isSafari: ua.includes("safari/") && !ua.includes("chrome/"), | ||
| }; | ||
| } | ||
|
|
There was a problem hiding this comment.
This is mixing platform, browser etc
Why do we need to detect windows and macos?
Comment on lines
+296
to
+297
| // IME確定後の入力イベントをプラットフォームに応じて処理 | ||
|
|
There was a problem hiding this comment.
Please keep the previous comment. Also the comments should be in english
Comment on lines
+305
to
+307
| } else if (this.platformInfo.isElectron) { | ||
| // Electronでは確実に非同期実行 | ||
| setTimeout(triggerInput, 0); |
There was a problem hiding this comment.
Why do we need to do that?
Comment on lines
+315
to
+325
| // IME composition状態の統合的な判定 | ||
| const nativeEvent = event.nativeEvent; | ||
| const isNativeComposing = nativeEvent && nativeEvent.isComposing; | ||
|
|
||
| // プラットフォーム固有の追加チェック | ||
| const isPlatformSpecificComposing = ( | ||
| (this.platformInfo.isMac && this.platformInfo.isSafari && event.which === 229) || | ||
| ((this.platformInfo.isWindows || this.platformInfo.isElectron) && event.which === 229) | ||
| ); | ||
|
|
||
| return !!(this.isIMEComposing || isNativeComposing || isPlatformSpecificComposing); |
There was a problem hiding this comment.
Keep the original comments and please explain why is it needed
Comment on lines
+404
to
+405
| // IME composition中は確定イベント以外を無視 | ||
| if (this.isIMEComposing && event.inputType !== "insertCompositionText") { |
| return; | ||
| } | ||
|
|
Comment on lines
+507
to
+523
| // IME composition中は全てのキーイベントを無視 | ||
| if (this.isComposing(event)) { | ||
| return; | ||
| } | ||
|
|
||
| // プラットフォーム固有のIME処理 | ||
| if (this.platformInfo.isMac && this.platformInfo.isSafari && event.which === 229) { | ||
| // Safariの追加のkeyDownを無視 | ||
| event.stopPropagation(); | ||
| return; | ||
| } | ||
|
|
||
| // Windows/ElectronでのIMEキーコード229処理 | ||
| if ((this.platformInfo.isWindows || this.platformInfo.isElectron) && event.which === 229) { | ||
| // Windows IMEのキーコード229を適切に処理 | ||
| return; | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit addresses input issues with Japanese IME (Input Method Editor) where pressing Enter to confirm IME suggestions would create unwanted line breaks instead of properly confirming the input.
Changes include:
Fixes IME input issues on:
🤖 Generated with Claude Code
Checklist
public/exportedsymbols have accurate TSDoc documentation.