Skip to content

Enhancement: Save image on CTRL+S #30330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

ioalexander
Copy link
Contributor

Enhancement: Prevent browser default behavior when pressing Ctrl + S on an open image, which would otherwise trigger image saving.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

@ioalexander ioalexander requested a review from a team as a code owner July 16, 2025 17:53
@ioalexander ioalexander requested review from dbkr and t3chguy July 16, 2025 17:53
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jul 16, 2025
@ioalexander
Copy link
Contributor Author

Old PR: #30306

@ioalexander ioalexander mentioned this pull request Jul 16, 2025
3 tasks
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! All looks good now.

@dbkr dbkr added this pull request to the merge queue Jul 17, 2025
Merged via the queue into element-hq:develop with commit 77cb4b3 Jul 17, 2025
36 of 39 checks passed
@dbkr dbkr mentioned this pull request Jul 30, 2025
dbkr added a commit that referenced this pull request Jul 31, 2025
...when downloading encrypted attachments (regressed by #30330).

Also adds tests for the tooltips and fix the tests so they don't pollute
mocks / dialogs.
@dbkr dbkr mentioned this pull request Jul 31, 2025
4 tasks
github-merge-queue bot pushed a commit that referenced this pull request Jul 31, 2025
...when downloading encrypted attachments (regressed by #30330).

Also adds tests for the tooltips and fix the tests so they don't pollute
mocks / dialogs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants