Skip to content

Conversation

suse-coder
Copy link

This should fix that
#615

This should fix that 
element-hq#615
@suse-coder suse-coder requested a review from a team as a code owner July 31, 2025 21:16
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@benbz benbz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned in #615 (comment) we'd only be happy with experimental and policy being underrides, and so overridable with user config. This change makes everything overridable. config.yaml will need to be split into 2 files with appropriate settings in each.

If there's other settings you think should be overridable with user config, I'm happy to have a discussion

@suse-coder
Copy link
Author

What about removing it: access_token_ttl fully from that (as the other experimental settings are also not there). So everybody can choose his value.

@benbz
Copy link
Member

benbz commented Aug 1, 2025

What about removing it: access_token_ttl fully from that (as the other experimental settings are also not there). So everybody can choose his value.

We've discussed this internally and this is also an acceptable solution. On reflection we think the original trigger we had for raising the access_token_ttl has been resolved

@benbz
Copy link
Member

benbz commented Sep 18, 2025

Closing as CLA was never signed and change in this PR was not appropriate

#745 will accomplish what this PR wanted

@benbz benbz closed this Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants