Skip to content

Add option to allow registrations that begin with '_' #18262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

hex5f
Copy link

@hex5f hex5f commented Mar 23, 2025

This commit resolves a long-standing question dating back to Jira.

leonerd: Should this be a configuration option? We don't want to allow
new user signups beginning with _ on matrix.org, because of clashes
with ASes; but maybe other sites wouldn't mind that?

As this may result in clashes with AppService namespaces, it is disallowed by default. Homeservers which provision users from an external identity provider may find this useful.

Fixes: SYN-738

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct
    (run the linters)

@hex5f hex5f requested a review from a team as a code owner March 23, 2025 05:00
@CLAassistant
Copy link

CLAassistant commented Mar 23, 2025

CLA assistant check
All committers have signed the CLA.

@hex5f hex5f force-pushed the config-allow-underscore-prefixed-registration branch 2 times, most recently from b18ba5a to f94b083 Compare March 23, 2025 05:04
This commit resolves a long-standing question dating back to Jira.

> leonerd: Should this be a configuration option? We don't want to allow
> new user signups beginning with `_` on matrix.org, because of clashes
> with ASes; but maybe other sites wouldn't mind that?

As this may result in clashes with AppService namespaces, it is
disallowed by default. Homeservers which provision users from an
external identity provider may find this useful.

Fixes: SYN-738
@hex5f hex5f force-pushed the config-allow-underscore-prefixed-registration branch from 48283b6 to b2c20f2 Compare April 4, 2025 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants