Skip to content

Stabilize support for custom profile fields. #18635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 17, 2025

Conversation

clokep
Copy link
Contributor

@clokep clokep commented Jul 2, 2025

Implements stable support for arbitrary profile fields but essentially switching the implementation to the previous experimental version.

This maintains backward plasticity with the experimental feature as a transitional measure, but updates the tests to test the stable paths.

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@clokep clokep marked this pull request as ready for review July 9, 2025 10:37
@clokep clokep requested a review from a team as a code owner July 9, 2025 10:37
Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on the whole! Just a couple question below.

Thank you for doing this!

@clokep
Copy link
Contributor Author

clokep commented Jul 17, 2025

Thanks @anoadragon453, should be ready for another look.

Copy link
Member

@anoadragon453 anoadragon453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@anoadragon453 anoadragon453 merged commit 8499131 into element-hq:develop Jul 17, 2025
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants