-
Notifications
You must be signed in to change notification settings - Fork 358
Stabilize support for custom profile fields. #18635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the whole! Just a couple question below.
Thank you for doing this!
Thanks @anoadragon453, should be ready for another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
Implements stable support for arbitrary profile fields but essentially switching the implementation to the previous experimental version.
This maintains backward plasticity with the experimental feature as a transitional measure, but updates the tests to test the stable paths.
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.