Skip to content

Ensure we /send PDUs which pass canonical JSON checks #18641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Ensure we /send PDUs which pass canonical JSON checks #18641

wants to merge 2 commits into from

Conversation

kegsay
Copy link
Contributor

@kegsay kegsay commented Jul 3, 2025 •
edited
Loading

Pull Request Checklist

Fixes #18554

Looks like this was missed when it was implemented.

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

@kegsay kegsay requested a review from a team as a code owner July 3, 2025 08:27
reivilibre
reivilibre approved these changes Jul 17, 2025
View reviewed changes
changelog.d/18641.bugfix
@@ -0,0 +1 @@
Ensure PDUs sent via `/send` pass canonical JSON checks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Ensure PDUs sent via `/send` pass canonical JSON checks.
Ensure all PDUs sent via `/send` pass canonical JSON checks.

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reivilibre reivilibre reivilibre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

synapse sends outbound federation containing non-canonical json, *blocking all future federation attempts if the remote server rejects it*
2 participants
@kegsay @reivilibre