Skip to content

Better explain which context the task is run in when using run_in_background(...) or run_as_background_process(...) #18906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2025
Merged

Better explain which context the task is run in when using run_in_background(...) or run_as_background_process(...) #18906

merged 2 commits into from
Sep 12, 2025

Conversation

MadLittleMods
Copy link
Contributor

@MadLittleMods MadLittleMods commented Sep 10, 2025 •
edited
Loading

Better explain which context the task is run in when using run_in_background(...) or run_as_background_process(...)

Follow-up to #18900

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Code style is correct (run the linters)

MadLittleMods
MadLittleMods commented Sep 10, 2025
View reviewed changes
changelog.d/18906.misc
@@ -0,0 +1 @@
Better explain how we manage the logcontext in `run_in_background(...)` and `run_as_background_process(...)`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same changelog as #18900 so they merge

@MadLittleMods MadLittleMods marked this pull request as ready for review September 10, 2025 22:24
@MadLittleMods MadLittleMods requested a review from a team as a code owner September 10, 2025 22:24
@MadLittleMods MadLittleMods merged commit 7ecfe8b into develop Sep 12, 2025
76 of 78 checks passed
@MadLittleMods MadLittleMods deleted the madlittlemods/clarify-which-context-task-runs-in-run-in-background branch September 12, 2025 14:29
@MadLittleMods
Copy link
Contributor Author

Thanks for the review @erikjohnston 🐠

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikjohnston erikjohnston erikjohnston approved these changes

Assignees
No one assigned
Labels
A-Docs A-Logging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MadLittleMods @erikjohnston