-
Couldn't load subscription status.
- Fork 404
Just fixed a typo. #19072
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Just fixed a typo. #19072
Conversation
change completed to complete
|
|
| The following fields are returned in the JSON response body: | ||
|
|
||
| - `status` - string - one of scheduled/active/completed/failed, indicating the status of the redaction job | ||
| - `status` - string - one of scheduled/active/complete/failed, indicating the status of the redaction job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this corresponds to TaskStatus
synapse/synapse/types/__init__.py
Lines 1542 to 1553 in da6c0ca
| class TaskStatus(str, Enum): | |
| """Status of a scheduled task""" | |
| # Task is scheduled but not active | |
| SCHEDULED = "scheduled" | |
| # Task is active and probably running, and if not | |
| # will be run on next scheduler loop run | |
| ACTIVE = "active" | |
| # Task has completed successfully | |
| COMPLETE = "complete" | |
| # Task is over and either returned a failed status, or had an exception | |
| FAILED = "failed" |
If we're going to use the actual values, we should probably use some code snippets for them:
| - `status` - string - one of scheduled/active/complete/failed, indicating the status of the redaction job | |
| - `status` - string - one of `scheduled`/`active`/`complete`/`failed`, indicating the status of the redaction job |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i don't know it was my first PR
|
|
||
|
|
||
| **Response** | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the PR checklist (was in the PR description template), this needs a changelog entry -> changelog.d/19072.doc
- Pull request includes a changelog file. The entry should:
- Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from
EventStoretoEventWorkerStore.".- Use markdown where necessary, mostly for
code blocks.- End with either a period (.) or an exclamation mark (!).
- Start with a capital letter.
- Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
Just fixed a typo .
Fix #18338
Change
completedtocomplete.Contributed by @neuark .