support count_true and count_false for boolean columns in BigQuery #610
Conversation
| @@ -4,6 +4,7 @@ | |||
| 'column_any_type': ['null_count', 'null_percent', 'not_null_percent'], | |||
| 'column_string': ['min_length', 'max_length', 'average_length', 'missing_count', 'missing_percent', 'not_missing_percent'], | |||
| 'column_numeric': ['min', 'max', 'zero_count', 'zero_percent', 'not_zero_percent', 'average', 'standard_deviation', 'variance', 'sum'] | |||
There was a problem hiding this comment.
You're missing a semicolon here at the end
There was a problem hiding this comment.
This is why the tests fail
There was a problem hiding this comment.
@noaKurman Ah when I merged main into my branch, I missed it when resolving the conflicts. It is ready now!
|
Hey @suelai, sorry for the long delay 😓 Im here now so lets do it 😎 there seems to be a small issue here, you are missing a comma at the end of the line, like so: after that i believe that everything should work and this could be merged 🙏 |
Great, fixed in c0a60a6 |
|
Awesome! the tests are currently running here, and seem to be doing well so far 🤞 |
|
@suelai thank you so much for this contribution 🙏! Keep your eyes peeled for the next release 👀 |
Allow
count_trueandcount_falsemetrics for boolean columns for BigQueryFrom my testing (I have blurred the table name):
closes elementary-data/elementary#1273