Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fixed exposure schema validity test err messages #628

Merged
merged 2 commits into from
May 28, 2024
Merged

🐛 Fixed exposure schema validity test err messages #628

merged 2 commits into from
May 28, 2024

Conversation

pushrbx
Copy link
Contributor

@pushrbx pushrbx commented Dec 8, 2023

Problem:
When the exposure schema validity test fails for data type mismatches, it doesn't show what was the received type.
Example:

different data type for the column ASOF_DATE DATE vs

This PR fixes that, and adds a new test for it.

Note:

  • The added test can be also merged together with test_exposure_schema_validity_correct_columns_and_invalid_type test, but I wasn't sure.

erikzaadi
erikzaadi approved these changes Jan 3, 2024
View reviewed changes
Copy link
Contributor

@erikzaadi erikzaadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@haritamar haritamar merged commit a14a6e1 into elementary-data:master May 28, 2024
2 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikzaadi erikzaadi erikzaadi approved these changes

@haritamar haritamar haritamar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pushrbx @erikzaadi @haritamar