Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ignore_small_changes param to column anomalies #644

Merged
merged 3 commits into from
Jan 8, 2024
Merged

add ignore_small_changes param to column anomalies #644

merged 3 commits into from
Jan 8, 2024
+66 −1

Conversation

ellakz
Copy link
Contributor

@ellakz ellakz commented Jan 4, 2024

No description provided.

@linear Linear
Copy link

linear bot commented Jan 4, 2024

ELE-2032 add not_null, not_missing and not_zero metrics to column anomalies

@ellakz ellakz requested a review from dapollak January 4, 2024 20:08
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 4, 2024

👋 @ellakz
Thank you for raising your pull request.
Please make sure to add tests and document all user-facing changes.
You can do this by editing the docs files in the elementary repository.

@ellakz ellakz force-pushed the ele-2032-ignore-small-changes-column-anomalies branch 3 times, most recently from 4f83957 to 751329d Compare January 4, 2024 21:06
@ellakz ellakz force-pushed the ele-2032-ignore-small-changes-column-anomalies branch from 751329d to c2775cb Compare January 4, 2024 21:36
@AvivZikelDY
Copy link
Contributor

Hi ella, #643 I added this pr earlier as well :)

@ellakz ellakz closed this Jan 7, 2024
@ellakz ellakz reopened this Jan 7, 2024
@ellakz ellakz removed the request for review from dapollak January 7, 2024 14:03
@ellakz ellakz force-pushed the ele-2032-ignore-small-changes-column-anomalies branch from 7218d79 to 83690c1 Compare January 7, 2024 14:05
@ellakz ellakz merged commit 3f52dad into master Jan 8, 2024
10 of 11 checks passed
@ellakz ellakz deleted the ele-2032-ignore-small-changes-column-anomalies branch January 8, 2024 07:04
ellakz added a commit that referenced this pull request Jan 8, 2024
@ellakz
Revert "Merge pull request #644 from elementary-data/ele-2032-ignore-…
37bc373 
…small-changes-column-anomalies"

This reverts commit 3f52dad, reversing
changes made to 705ab3c.

# Conflicts:
#	macros/edr/tests/test_column_anomalies.sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haritamar haritamar haritamar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellakz @AvivZikelDY @haritamar