Support all anomaly vars on all configuration levels #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @ofek1weiss |
ofek1weiss
commented
Feb 8, 2024
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| def pytest_addoption(parser): | |||
| parser.addoption("--target", action="store", default="postgres") | |||
| parser.addoption("--skip-init", action="store_true", default=False) | |||
There was a problem hiding this comment.
the tests i added just do run-operation and did not need the models, this flag was quite useful
ofek1weiss
commented
Feb 8, 2024
| @@ -1,13 +1,12 @@ | |||
| {% macro get_test_argument(argument_name, value, model_graph_node) %} | |||
There was a problem hiding this comment.
differentiate between undefined and None
ofek1weiss
commented
Feb 8, 2024
| @@ -19,8 +19,6 @@ | |||
| {# We use this macro to define and call vars, as the global vars defined in dbt_project.yml | |||
| of the package are not accessible at on-run-start and on-run-end #} | |||
| {% set default_config = { | |||
| 'detection_period': elementary.get_period_default_var(period='day', count=2), | |||
| 'training_period': elementary.get_period_default_var(period='day', count=14), | |||
There was a problem hiding this comment.
as these overwrite days_back and backfill_days, these default var values overwrite model/test values
elongl
approved these changes
Feb 8, 2024
ofek1weiss
deleted the
ele-2478-support-all-anomaly-detection-parameters-on-a-model-and-vars
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.