Ele 3034 additional package bugfixes #707
Conversation
|
👋 @haritamar |
| @@ -19,6 +19,11 @@ def test_artifacts_caching(dbt_project: DbtProject): | |||
| second_row = read_model_artifact_row(dbt_project) | |||
| assert first_row == second_row, "Artifacts are not cached at the on-run-end." | |||
|
|
|||
|
|
|||
| def test_artifacts_updating(dbt_project: DbtProject): | |||
There was a problem hiding this comment.
Separated the original test to two, with the second test also running for dbt 1.3.0
| @@ -1,7 +1,7 @@ | |||
| {% macro count_true(column_name) -%} | |||
| coalesce(sum(case when cast({{ column_name }} as {{ elementary.edr_type_bool() }}) is true then 1 else 0 end), 0) | |||
| coalesce(sum(case when cast({{ column_name }} as {{ elementary.edr_type_bool() }}) = true then 1 else 0 end), 0) | |||
There was a problem hiding this comment.
The "is true" syntax seems to work only for BQ, where = seems to always work and I think is good enough
haritamar
force-pushed
the
ele-3034-additional-package-bugfixes
branch
from
e084062 to
0b0ec80
Compare
| @@ -62,7 +62,7 @@ | |||
| {% do return(relations) %} | |||
| {% endmaterialization %} | |||
|
|
|||
| {% materialization incremental, adapter="athena", supported_languages=["sql"] %} | |||
| {% materialization incremental, adapter="athena", supported_languages=["sql", "python"] %} | |||
There was a problem hiding this comment.
Athena added support for python models and because of us they don't work, so added here to the supported languages.
Added to trino as well because there's actually no harm in doing so (we did the same for redshift even though it doesn't yet support Python models)
No description provided.