Fixed Athena temp tables cleaning #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added clean_up_tables to handle_tests_results and clean_elementary_test_tables to delete files from S3
haritamar
reviewed
May 28, 2024
| @@ -160,6 +160,7 @@ | |||
|
|
|||
| {% if not elementary.has_temp_table_support() %} | |||
| {% do adapter.drop_relation(temp_relation) %} | |||
| {% do adapter.clean_up_table(temp_relation) %} | |||
There was a problem hiding this comment.
@bebbo203 - this fails in Databricks since it doesn't have this column.
I'm guessing you should use fully_drop_relation here as well?
There was a problem hiding this comment.
Hi! Sorry for the mistake. I've updated the branch by pushing a fix
haritamar
reviewed
May 28, 2024
|
I think this looks good! |
haritamar
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1514.
Specifically for dbt-athena-community, this fix aims to clean the temporary tables in a better way, including dropping files from S3 in case of external tables.