Files.IconInfo: Replace Gtk.IconInfo and Gdk.Pixbuf #2550
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremypw
changed the title
|
As this fixes CI it makes sense to consider this for merging into the skeleton first. |
jeremypw
added
Gtk4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes Files.IconInfo functional. Attempts to keep pixbufs failed as these cannot (at least easily) from ThemedIcons.
It was replaced with
Gdk.Paintablewhich is an interface implemented by bothIconPaintableandTexture. Images can readily be obtained from them in the same way as from pixbufs. It should be straightforward to use them with dynamic views although the cellrenderers used in the legacy views will need substantial changes.