-
-
Notifications
You must be signed in to change notification settings - Fork 79
Add preview column to Column View #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add preview column to Column View #2620
Conversation
…: inject Properties into new slot
…le selection. Next: draw info instead of same dir contents
…_details_draw, because Tree and Icon view could also get a details slot, why not? Also, I don't have acess to Pango in Miller. Adds a call to on_details_draw to Gdk.Key.right in Miller
…eate DetailsColumn: a mashup of SidebarWindow with PropertiesWindow contents
…ng. Also, image preview
…n_trash_orig copy-pasta
… VERTICAL because magic constants suck
…nd of silly in Miller columns...
![]() @jeremypw @alainm23 wutcha'll think? I'd like to pad the Box to the middle of the colpane, but this is my first time coding in Vala (Love it!) and using the Gtk/Gdk libs, which i haven't figured out how to "pad" like in CSS. Open to feedback! P.S: Oh yeah, and padding between the info_grid items, as well |
@leonardo-lemos I took it out of draft mode a little too quickly and forgot about text preview. No clue what pattern to follow to pull that off, and I know it's technically out of scope for the issue, but I feel it's in the spirit of mirroring OSX' preview panel, yes? Thoughts? |
@shiruken1 I applaud you for having the courage to get to grips with Files code - its not easy! The screenshot looks very promising. I'll take some time to go through the code and get back to you with specific issues. I suspect we will want to have a preference switch to turn this feature on and off. @danirabbit Are you willing to extend Files in this way? I know you have expressed doubts about file previewing before but there seems to be a significant demand for it. I have no objection if implemented well. |
Thanks! Thankfully my C# coding came in handy to get my eyes adjusted (10+ years of Node and Python) but I gotta say the codebase is neat and tidy for the most part, making it easy for me to pattern-match. I did wanna propose pulling construct_info_panel out of PropertiesWindow and placing it in AbstractPropertiesDialog, so DetailsColumn could piggy-back off of as much as possible to keep the code DRY. Lmk! |
@shiruken1 OK, let me know if you need more help. I am not sure what remaining issue with up/down directory you mean - note that if it also occurs in |
@jeremypw thanks. Yeah main doesn't have an issue navigating up/down directories with the keyboard (or should I say left/right?) Also, just to make sure, you don't feel the need for throttling anymore? You had asked:
Let me know and I can put that back in. I'll be trying to figure out why navigating in and out of directories is broken, in the meantime |
That folder navigation issue was fixed in my branch at one point. Not sure why its re-appeared - investigating. |
You should add the throttle on the |
@shiruken1 The navigation issue is caused by Miller handling the Up/Down keys - which it does not need to do now. |
@shiruken1 I have pushed a PR showing how I suggest you throttle the drawing as well as removing the unnecessary key handling in Miller |
Fix navigation, throttle drawing
@jeremypw aaah, I guess my super duper update-main-and-feature-branch-from-upstream overwrote something of yours. My apologies and thank you for helping get this across the finish line! 🎉 Works' been a little heavy this last week, so I really appreciate it 🏆 |
|
@teamcons |
@shiruken1 Once we are happy with the functionality I'll go through and fix any remaining code-style issues. They don't all show up as lint. |
@jeremypw sounds great. Let me know if there's anything I can do to help out further. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit-picking comments/suggestions on code-style.
- Use
var
when the type is implicit in the assignment - Whitespace after closing brace of code blocks
- Whitespace after statements only where the focus changes (generally speaking but this is open to interpretation and personal preference)
- Don't make format changes to old code that is not being modified in order to minimise the diff.
Co-authored-by: Jeremy Wootten <[email protected]>
Co-authored-by: Jeremy Wootten <[email protected]>
Co-authored-by: Jeremy Wootten <[email protected]>
Co-authored-by: Jeremy Wootten <[email protected]>
Co-authored-by: Jeremy Wootten <[email protected]>
Co-authored-by: Jeremy Wootten <[email protected]>
@shiruken1 Yes, sorry I should have made another PR with that many suggestions I guess. You can batch them up rather than commit separately I think. Looks like I introduced some lint which is a disadvantage of making changes on Github. Just some trailing white space - can you fix that please? |
No worires! I tried putting everything in commit 9068a04, but GH was still showing your comments as unresolved. Just pushed a cleanup commit to handle trailing white space 🚀 |
Fixes #1601 and gives text preview for "text/*" and "application/sql" mimetypes