Fix default audio interface should_stop attribute #630
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize
should_stopand related resources in__init__and add robustness checks tostop()methods to preventAttributeError.The
should_stopattribute and other resources (likeoutput_thread,in_stream,out_stream,p) were only initialized in thestart()method. Ifstop()was called beforestart(), it would result in anAttributeError. This PR ensures these attributes are always present and safely handled, preventing crashes in scenarios likeconversation.end_session()being called without a priorstart().Slack Thread