Feature/macro #22
Merged
Feature/macro #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beyama
changed the base branch from
main
to
feature/remove-background-from-layout-and-context-from-builder
zahnooo
reviewed
Feb 20, 2024
…ntext-from-builder # Conflicts: # Example/Example App/StreamDeckLayoutView.swift # Sources/StreamDeckKit/Views/StreamDeckLayout.swift # Sources/StreamDeckSimulator/Views/StreamDeckSimulatorView.swift # Tests/StreamDeckSDKTests/Helper/TestViews.swift
…builder' into feature/macro # Conflicts: # Package.swift # Tests/StreamDeckSDKTests/Helper/TestViews.swift
Base automatically changed from
feature/remove-background-from-layout-and-context-from-builder
to
main
February 20, 2024 11:01
# Conflicts: # Sources/StreamDeckKit/Layout/StreamDeckViewContext.swift # Tests/StreamDeckSDKTests/Helper/TestViews.swift
r-dent
reviewed
Feb 20, 2024
| @@ -32,12 +44,6 @@ public protocol StreamDeckView: View { | |||
| @MainActor @ViewBuilder var streamDeckBody: Self.Content { get } | |||
There was a problem hiding this comment.
Please also add documentation for streamDeckBody and context properties.
…ate additional view properties
…ort the macro in its tests
…acro and also generate docs
r-dent
approved these changes
Feb 22, 2024
* Documentation for Stream Deck Layout * Move StreamDeckSession.setUp into PreviewView of Simulator * Renamings * Add two examples: Stateless and Stateful * Add ExampleDataModel to share app state with stream deck layout * Code structure * Extend EnvironmentValues for ExampleDataModel, and In Simulator.PreviewView render only the view without the using the session * Add an example for an animated StreamDeckLayout * Renaming * Simplify background colors of dial area * Update layout docs * Update some code comments --------- Co-authored-by: Christiane Göhring <[email protected]> Co-authored-by: Roman Schlagowsky <[email protected]> Co-authored-by: Alexander Jentz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.