Add Support for 1.21.#80
Conversation
* Change min java version to 21.
* Use github actions to directly set verison tag.
|
Why was JGitVer removed, was it causing issues? And what is the impact on development builds/anything without a tag? Will it always use the hardcoded version in the POM? Still haven't dived deep into your changes on the components, but is there no available library capable of handling this? Since you bumped JDK to 21 is MC 1.20 no longer supported/what was the reason? Thanks for working on this. |
|
Thanks for the preliminary review.
JGitVer was causing issues on my local development build; can't say whether that was an issue with my local setup, maven version, or something else. I was trying to find more recently maintained alternatives, but I didn't see anything with the same functionality.
Yeah it will use the
The main problem is fetching the hover component data of an item in Spigot and converting that to something usable for adventure. I haven't developed against the modern version of Spigot, so there may be better solutions out there. What I saw was that Spigot 1.21 introduced a ItemMeta#getComponentString
|
This PR updates the project to build for Paper/Spigot 1.21+.
Changes
Changes:
getComponentStringwhich returns an SNBT formatted string. A parsing helper (ComponentHelper.java) was created to manually translate the SNBT components into JSON-formatted data that can be ingested by adventure.User-Facing Changes:
Testing
Tested on Spigot 1.21.8 by auctioning items with different lore, enchantments, names.
Gaps:
Disclosure: Modifications were made in part with OpenAI GPT-5.5.