Skip to content

Conversation

brzep
Copy link
Contributor

@brzep brzep commented Jul 9, 2025

Depayloads H264 from RTP. Supports following NALU types: Single NALU, STAP-A, FU-A.

@brzep brzep force-pushed the brzep/h264-depayloader branch from 646eb37 to aeea29d Compare July 9, 2025 14:51
Copy link

codecov bot commented Jul 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.97%. Comparing base (38e05e2) to head (be1ad65).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
+ Coverage   87.79%   87.97%   +0.18%     
==========================================
  Files          54       59       +5     
  Lines        2752     2803      +51     
==========================================
+ Hits         2416     2466      +50     
- Misses        336      337       +1     
Files with missing lines Coverage Δ
lib/ex_webrtc/rtp/depayloader.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp/h264/depayloader.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp/h264/nal_formats/fu.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp/h264/nal_formats/fu/header.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp/h264/nal_formats/stap_a.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp/h264/nal_header.ex 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38e05e2...be1ad65. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@brzep brzep requested review from mickel8 and sgfn July 9, 2025 14:54
Copy link
Member

@sgfn sgfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@brzep brzep force-pushed the brzep/h264-depayloader branch from 3eb806f to 43407a3 Compare July 11, 2025 09:12
@brzep brzep requested a review from sgfn July 11, 2025 13:18
Copy link
Member

@sgfn sgfn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could add tests for the other modules (fu, fu/header, stap_a, nal_header), like in test/rtp/vp8/payload_test.exs or test/rtp/av1/ as well. But I won't push for this, as we have other things on the roadmap -- if @mickel8 approves, you can merge 👍

@brzep brzep merged commit d165ccb into master Jul 31, 2025
3 checks passed
@brzep brzep deleted the brzep/h264-depayloader branch July 31, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants