-
Notifications
You must be signed in to change notification settings - Fork 24
Add H264 RTP depayloader #224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
646eb37
to
aeea29d
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #224 +/- ##
==========================================
+ Coverage 87.79% 87.97% +0.18%
==========================================
Files 54 59 +5
Lines 2752 2803 +51
==========================================
+ Hits 2416 2466 +50
- Misses 336 337 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
3eb806f
to
43407a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if we could add tests for the other modules (fu, fu/header, stap_a, nal_header
), like in test/rtp/vp8/payload_test.exs
or test/rtp/av1/
as well. But I won't push for this, as we have other things on the roadmap -- if @mickel8 approves, you can merge 👍
Depayloads H264 from RTP. Supports following NALU types: Single NALU, STAP-A, FU-A.