Recording converter fixes #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mickel8
approved these changes
Jun 17, 2025
| @@ -0,0 +1,95 @@ | |||
| defmodule ExWebRTC.Recorder.Converter.Pipeline do | |||
There was a problem hiding this comment.
A short doc explaining what this pipeline does would be appreciated
| @moduledoc false | ||
| use Membrane.Source | ||
|
|
||
| def_options( |
There was a problem hiding this comment.
including membrane_core in .formatter.exs should help here
| * `:reorder_buffer_size` - Size of the buffer used for reordering late packets. `#{@default_reorder_buffer_size}` by default. | ||
| Increasing this value may help with "Decoded late RTP packet" warnings, | ||
| but keep in mind that larger values slow the conversion process considerably. | ||
| * `:reencode_ctx` - If passed, Converter will reencode the video using FFmpeg. |
There was a problem hiding this comment.
Let's add info when this is helpful
lib/ex_webrtc_recorder/converter.ex
Outdated
|
|
||
| :audio -> | ||
| %{nil: convert_audio_track(id, output_path, packets |> Map.values() |> hd())} | ||
| %{nil: get_audio_track_context(packets |> Map.values() |> hd())} |
| ) do | ||
| stream_map = | ||
| Enum.reduce(manifest, %{}, fn {id, track}, stream_map -> | ||
| Enum.reduce(manifest, %{}, fn {_id, track}, stream_map -> |
There was a problem hiding this comment.
A couple of comments explaining step by step what we are doing here would be cool, e.g.:
- Read tracks
- convert tracks to webm files
- mux webm files into a single file
lib/ex_webrtc_recorder/converter.ex
Outdated
| {:ok, _sup, pid} = Pipeline.start_link(video_stream, audio_stream, output_file) | ||
| Process.monitor(pid) | ||
|
|
||
| # FIXME: Possible RC here? |
|
@mickel8 Any issue with bumping |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.