Add codec information to manifest #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgfn
reviewed
Sep 1, 2025
sgfn
reviewed
Sep 2, 2025
| } | ||
| end | ||
|
|
||
| defp parse_codec(nil), do: nil |
Member
There was a problem hiding this comment.
I believe this will be "nil" if read from the serialized JSON.
If you have the time, you could consider writing unit tests for this module -- since it looks like we'll continue extending the Recorder, adding tests will help ensure basic functionality like this keeps working with further changes
Member
Author
There was a problem hiding this comment.
I assume the value returned by Jason.decode!(json_string) is passed to from_json!() (see converter.ex:134); Jason.decode/1 converts JSON null to Elixir nil, and I added tests to confirm this.
Member
There was a problem hiding this comment.
Right, my bad. I assumed it behaved the same way as our rid_map, where we do "nil" -> nil ourselves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the first RTP packet containing codec information is received, we update our track_data to include this codec.