Skip to content

feat: add onStepFinish callback to text generation functions #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
standujar wants to merge 2 commits into
base: 1.x
Choose a base branch
from
Open

feat: add onStepFinish callback to text generation functions #18

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
211c015
feat: add onStepFinish callback to text generation functions
standujar Nov 10, 2025
12b084d
fix: handle errors in onStepFinish callback during text generation
standujar Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion src/models/text.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,10 @@ async function generateTextWithModel(
params: GenerateTextParams & {
tools?: Record<string, Tool>;
toolChoice?: ToolChoice<Record<string, Tool>>;
onStepFinish?: (stepResult: any) => void | Promise<void>;
},
): Promise<string | ToolResponse> {
const { prompt, stopSequences = [], tools, toolChoice } = params;
const { prompt, stopSequences = [], tools, toolChoice, onStepFinish } = params;
const temperature = params.temperature ?? 0.7;
const frequencyPenalty = params.frequencyPenalty ?? 0.7;
const presencePenalty = params.presencePenalty ?? 0.7;
Expand Down Expand Up @@ -72,6 +73,7 @@ async function generateTextWithModel(

if (tools) {
(generateParams as any).onStepFinish = async (stepResult: any) => {
// Internal capture logic
if (stepResult.toolCalls && stepResult.toolCalls.length > 0) {
capturedToolCalls = [
...capturedToolCalls,
Expand All @@ -92,6 +94,15 @@ async function generateTextWithModel(
capturedToolResults = [...capturedToolResults, ...toolResultsFromContent];
}
}

// Call user-provided callback if provided
if (onStepFinish) {
try {
await onStepFinish(stepResult);
} catch (error) {
logger.error('[OpenRouter] Error in onStepFinish callback:', error instanceof Error ? error.message : String(error));
}
}
};
}

Expand Down Expand Up @@ -137,6 +148,7 @@ export async function handleTextSmall(
params: GenerateTextParams & {
tools?: Record<string, Tool>;
toolChoice?: ToolChoice<Record<string, Tool>>;
onStepFinish?: (stepResult: any) => void | Promise<void>;
},
): Promise<string | ToolResponse> {
return generateTextWithModel(runtime, ModelType.TEXT_SMALL, params);
Expand All @@ -150,6 +162,7 @@ export async function handleTextLarge(
params: GenerateTextParams & {
tools?: Record<string, Tool>;
toolChoice?: ToolChoice<Record<string, Tool>>;
onStepFinish?: (stepResult: any) => void | Promise<void>;
},
): Promise<string | ToolResponse> {
return generateTextWithModel(runtime, ModelType.TEXT_LARGE, params);
Expand Down