fix: remove PGlite :memory: artifacts blocking Windows git checkout#25
Open
dutchiono wants to merge 1 commit intoelizaos-plugins:alphafrom
Open
fix: remove PGlite :memory: artifacts blocking Windows git checkout#25dutchiono wants to merge 1 commit intoelizaos-plugins:alphafrom
dutchiono wants to merge 1 commit intoelizaos-plugins:alphafrom
Conversation
Four PGlite in-memory database directories were accidentally committed under typescript/:memory:<UUID>/ during test runs. These paths contain colons, which are valid on macOS/Linux but illegal as Windows filenames. This caused git checkout to fail on every Windows CI runner, blocking the Milady Electrobun release build for 3+ days. Fixes: - Remove all four typescript/:memory:<UUID>/ subtrees from git history - Add :memory:*/ and typescript/:memory:*/ to .gitignore - Update vitest.config.ts to set PGDATA env to OS tmpdir so PGlite never writes database files into the working tree during test runs Root cause: PGlite initializes with a :memory:<UUID> path that resolves relative to CWD when no explicit data directory is configured. On macOS/Linux the files are created silently and can be staged with git add -A. The PGDATA env redirect prevents this entirely.
|
Important Review skippedToo many files! This PR contains 300 files, which is 150 over the limit of 150. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (300)
You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
dutchiono
added a commit
to milady-ai/milady
that referenced
this pull request
Apr 7, 2026
elizaos-plugins/plugin-openrouter has PGlite :memory:<UUID> directories committed under typescript/ since the initial commit. These paths contain colons which Windows git rejects as invalid filenames, breaking every Windows submodule checkout and blocking the Electrobun 4-platform release. Temporary fix: redirect the submodule at milady-ai/plugin-openrouter (our fork) on a branch where the artifacts are removed and .gitignore + vitest.config.ts are updated to prevent recurrence. Upstream PR: elizaos-plugins/plugin-openrouter#25 Revert this when upstream merges and point back to elizaos-plugins at the merged commit. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes four PGlite in-memory database directories that were accidentally committed under `typescript/:memory:/` and prevents them from recurring.
Why
These paths contain colons, which are valid on macOS/Linux but illegal as Windows filenames. Every Windows git checkout of this repo fails with:
```
error: invalid path 'typescript/:memory:83863d27-7fd3-4e4a-ab21-9d8a7c6d4f4c/PG_VERSION'
fatal: Unable to checkout in submodule path 'plugins/plugin-openrouter'
```
This has been blocking the Milady Electrobun 4-platform release build on Windows CI for 3+ days (milady-ai/milady releases v2.0.0-alpha.133 and alpha.134 both blocked).
Root cause
PGlite initializes with a `:memory:` path that resolves relative to CWD when no explicit data directory is configured. On macOS/Linux the files land silently in the working tree and get swept up by `git add -A` during a release commit. Windows git then rejects them at checkout.
Changes
Validation