Add @tsmets/plugin-arcadia to registry#313
Add @tsmets/plugin-arcadia to registry#313Thomas-Smets wants to merge 1 commit intoelizaos-plugins:mainfrom
Conversation
WalkthroughA new plugin mapping entry was added to Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can generate walkthrough in a markdown collapsible section to save space.Enable the |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| "@theschein/plugin-polymarket": "github:Okay-Bet/plugin-polymarket", | ||
| "@token-metrics-ai/plugin-tokenmetrics": "github:token-metrics/plugin-tokenmetrics", | ||
| "@tonyflam/plugin-openchat": "github:Tonyflam/plugin-openchat", | ||
| "@tsmets/plugin-arcadia": "github:Thomas-Smets/plugin-arcadia", |
There was a problem hiding this comment.
The new entry uses 4 spaces of indentation while every other entry in the file uses 2 spaces. While the JSON remains valid, this breaks the formatting consistency of the registry file and may cause issues with automated JSON formatting checks or linters.
| "@tsmets/plugin-arcadia": "github:Thomas-Smets/plugin-arcadia", | |
| "@tsmets/plugin-arcadia": "github:Thomas-Smets/plugin-arcadia", |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@index.json`:
- Line 368: The dependency entry "@tsmets/plugin-arcadia":
"github:Thomas-Smets/plugin-arcadia" references a non-existent GitHub repo;
update the dependency by either replacing the value with a valid existing
repository (e.g., "github:Thomas-Smets/<existing-repo>" or a correct npm
package/version) or remove the "@tsmets/plugin-arcadia" key entirely from
index.json if the plugin is unmaintained, ensuring package managers no longer
attempt to resolve "github:Thomas-Smets/plugin-arcadia".
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| "@theschein/plugin-polymarket": "github:Okay-Bet/plugin-polymarket", | ||
| "@token-metrics-ai/plugin-tokenmetrics": "github:token-metrics/plugin-tokenmetrics", | ||
| "@tonyflam/plugin-openchat": "github:Tonyflam/plugin-openchat", | ||
| "@tsmets/plugin-arcadia": "github:Thomas-Smets/plugin-arcadia", |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the repository exists and has valid package.json
OWNER="Thomas-Smets"
REPO="plugin-arcadia"
echo "Checking repository existence..."
gh repo view "$OWNER/$REPO" --json name,description,isPrivate,defaultBranchRef
echo -e "\nFetching package.json from default branch..."
gh api "/repos/$OWNER/$REPO/contents/package.json" \
--jq '.content' | base64 -d | jq '{name, version, description}'
echo -e "\nChecking for v0.1.0 tag or release..."
gh api "/repos/$OWNER/$REPO/tags" --jq '.[] | select(.name | test("0\\.1\\.0|v0\\.1\\.0")) | {name, commit}'Repository: elizaos-plugins/registry
Length of output: 498
🌐 Web query:
Thomas-Smets/plugin-arcadia GitHub repository
💡 Result:
The GitHub repository Thomas-Smets/plugin-arcadia does not exist. Thomas-Smets is a GitHub user with 4 public repositories, none named plugin-arcadia. The user is a contributor to arcadia-finance repositories like accounts-v2, lending-v2, and asset-managers (top contributor in some), related to DeFi protocols. No evidence of a plugin-arcadia repo under this user or matching "plugin arcadia". Other Arcadia-related repos exist under different owners (e.g., ArcadiaPlugins, ArcadiaMCBE), but not linked to Thomas-Smets.
Citations:
- 1: https://github.com/Thomas-Smets
- 2: https://github.com/arcadia-finance/accounts-v2
- 3: https://github.com/orgs/arcadia-finance/people
- 4: https://linkedin.com/in/thomas-smets-a379a3123
- 5: https://github.com/arcadia-finance
- 6: https://github.com/arcadia-finance/lending-v2
🏁 Script executed:
#!/bin/bash
# Try unauthenticated curl to GitHub API for public repository info
OWNER="Thomas-Smets"
REPO="plugin-arcadia"
echo "Attempting to fetch public repository info via curl..."
curl -s "https://api.github.com/repos/$OWNER/$REPO" | jq '{name, description, private, fork, archived}'
echo -e "\nAttempting to fetch package.json via curl..."
curl -s "https://api.github.com/repos/$OWNER/$REPO/contents/package.json" | jq '.content' | base64 -d 2>/dev/null | jq '{name, version}' 2>/dev/null || echo "Could not decode package.json"Repository: elizaos-plugins/registry
Length of output: 301
The referenced repository does not exist.
The GitHub repository Thomas-Smets/plugin-arcadia cannot be resolved. Thomas-Smets' GitHub account contains 4 public repositories, none named plugin-arcadia. This dependency will fail to install or resolve when package managers attempt to fetch from the specified GitHub location. Update the reference to point to a valid, existing repository or remove this dependency if it is no longer maintained.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@index.json` at line 368, The dependency entry "@tsmets/plugin-arcadia":
"github:Thomas-Smets/plugin-arcadia" references a non-existent GitHub repo;
update the dependency by either replacing the value with a valid existing
repository (e.g., "github:Thomas-Smets/<existing-repo>" or a correct npm
package/version) or remove the "@tsmets/plugin-arcadia" key entirely from
index.json if the plugin is unmaintained, ensuring package managers no longer
attempt to resolve "github:Thomas-Smets/plugin-arcadia".
|
Closing: incorrect repository reference. Will resubmit with correct arcadia-finance org repo. |
1 participant
This PR adds @tsmets/plugin-arcadia to the registry.
Submitted by: @Thomas-Smets
Summary by CodeRabbit
@tsmets/plugin-arcadiaplugin is now available for use.Greptile Summary
This PR registers the
@tsmets/plugin-arcadiapackage in the elizaos-plugins registry. The plugin is described as a DeFi tool for managing concentrated liquidity on Uniswap and Aerodrome with automated rebalancing and yield optimization on Base.@tonyflam/plugin-openchatand@zane-archer/plugin-aimo-router)index.json— this should be corrected for consistencygithub:Thomas-Smets/plugin-arcadiafollows the correct format used by other entries in the registryConfidence Score: 4/5
github:owner/repoformat. The only issue is a cosmetic 4-space vs 2-space indentation inconsistency that doesn't affect JSON validity but breaks file formatting conventions.index.json.Important Files Changed
@tsmets/plugin-arcadiapointing togithub:Thomas-Smets/plugin-arcadia. Entry is correctly placed in alphabetical order between@tonyflamand@zane-archer, but uses 4-space indentation instead of the 2-space convention used by all other entries in the file.Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart TD A[PR: Add @tsmets/plugin-arcadia] --> B{Entry validation} B --> C[Alphabetical order ✅] B --> D[github: URL format ✅] B --> E[Indentation: 4 spaces ❌\nExpected: 2 spaces] C --> F[registry/index.json updated] D --> F E --> G[Style fix required] G --> FLast reviewed commit: "Add @tsmets/plugin-a..."
(2/5) Greptile learns from your feedback when you react with thumbs up/down!