Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: no reactivity transform #2600

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

patak-dev
Copy link
Member

Vue removed the experimental reactivity transform, and we would like Elk to dual as a learning tool for Vite, Nuxt, and Vue, so it is better we align with Vue's decision here.

After this PR, we'll update Vue to latest, before attempting to update Nuxt.

Copy link

stackblitz bot commented Feb 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for elk-docs canceled.

Name Link
🔨 Latest commit f8c067d
🔍 Latest deploy log https://app.netlify.com/sites/elk-docs/deploys/65d60c3e09bf3d0008c27611

Copy link

netlify bot commented Feb 21, 2024

Deploy Preview for elk-zone ready!

Name Link
🔨 Latest commit f8c067d
🔍 Latest deploy log https://app.netlify.com/sites/elk-zone/deploys/65d60c3e9687bc00082b6c84
😎 Deploy Preview https://deploy-preview-2600--elk-zone.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@danielroe danielroe added this pull request to the merge queue Feb 21, 2024
Merged via the queue into main with commit ccfa7a8 Feb 21, 2024
15 checks passed
@danielroe danielroe deleted the refactor/no-reactivity-transform branch February 21, 2024 15:22
@patak-dev
Copy link
Member Author

patak-dev commented Feb 21, 2024

For reference, @shuuji3 also said it tested basic UI functionalities in Discord and the app seems to be working fine

@haayman
Copy link
Contributor

haayman commented Feb 23, 2024

I'm seeing that it's no longer visible that a toot is a reply. It seems this is the only recent change that might cause this

image

@patak-dev
Copy link
Member Author

Would you open a new issue @haayman? With a link to that toot

@haayman
Copy link
Contributor

haayman commented Feb 23, 2024

done. #2608
No link to any toot though because it only shows in your own main timeline, so a direct link is useless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants