Skip to content

fix(wasm): accept order index as a string or number in SignCancelOrder and SignModifyOrder #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lowenhere wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(wasm): accept order index as a string or number in SignCancelOrder and SignModifyOrder #78

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c75857
fix(wasm): accept orderIndex as a string or number in SignCancelOrder
lowenhere Jul 3, 2026
9817702
fix(wasm): accept index as a string or number in SignModifyOrder
lowenhere Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions wasm/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -419,7 +419,17 @@ func main() {
if err != nil {
return wrapErr(err)
}
orderIndex := int64(args[1].Int())

var orderIndex int64
if args[1].Type() == js.TypeString {
orderIndex, err = strconv.ParseInt(args[1].String(), 10, 64)
if err != nil {
return wrapErr(err)
}
} else {
orderIndex = int64(args[1].Int())
}

skipNonce := uint8(args[2].Int())
nonce := int64(args[3].Int())

Expand Down Expand Up @@ -672,7 +682,17 @@ func main() {
if err != nil {
return wrapErr(err)
}
index := int64(args[1].Int())

var index int64
if args[1].Type() == js.TypeString {
index, err = strconv.ParseInt(args[1].String(), 10, 64)
if err != nil {
return wrapErr(err)
}
} else {
index = int64(args[1].Int())
}

baseAmount := int64(args[2].Int())
price := uint32(args[3].Int())
triggerPrice := uint32(args[4].Int())
Expand Down