Switch to techknowlogic/xgo, add linux/arm64 build target, implement github workflows, fix go.mod go version #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andsens
force-pushed
the
ft-linux-arm64
branch
3 times, most recently
from
b5e1e7f to
6dd5389
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this initially started with just trying to get an arm64 binary. But I couldn't get karalabe/xgo to work, so I followed the advice by @stoft and switched to techknowlogic/xgo and that works like a charm! (with go v1.22)
And then I just got carried away and added some GitHub actions as well, so now you have automatic testing and release building with caching to boot :-)
However, the
slicespackage that you are using inservice.godoesn't exist in go v1.18, so I had to bump the required version ingo.modto v1.21.I also remove the docker-compose call in the Makefile, it seemed to be a leftover from when you did containerized builds.Anyways, this fixes #53.
EDIT: I found out what the docker-compose call was for 🤦♂️ alpine/arm64 now also works