Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the async testing utils. #30

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Added the async testing utils. #30

merged 2 commits into from
Mar 19, 2024

Conversation

NiKuma0
Copy link

@NiKuma0 NiKuma0 commented Mar 18, 2024

Added async implementation of APIRequestFactory and APIClient.

Mostly this is a copy/paste of the rest framework implementation. However, I didn't inherit any classes (from the rest framework implementation) for a couple of reasons:

  1. The Django AsyncClient doesn't support follow, but the APIClient does.
  2. I'm not sure it's good practice to have such a long inheritance tree.

I'm open to discussion)

em1208
em1208 reviewed Mar 19, 2024
View reviewed changes
Copy link
Owner

@em1208 em1208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@em1208 em1208 merged commit a9a117f into em1208:main Mar 19, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@em1208 em1208 em1208 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NiKuma0 @em1208