lsp-copilot: Replace LSP server with the official GitHub one #4710
Conversation
| @@ -211,6 +211,7 @@ automatically, browse to %s." user-code verification-uri)) | |||
| ("$/progress" (lambda (&rest args) (lsp-message "$/progress with %S" args))) | |||
| ("featureFlagsNotification" #'ignore) | |||
| ("statusNotification" #'ignore) | |||
| ("didChangeStatus" #'ignore) | |||
There was a problem hiding this comment.
I'm seeing a bunch of Warning (lsp-mode): Unknown notification: didChangeStatus messages. Not too familiar w/ LSP, but do we need to set up some additional handling for these notifications?
https://github.com/orgs/github/packages/npm/package/copilot-language-server
The status is sent to the client as a didChangeStatus notification. Typically this would be conveyed to the user in a status bar icon or other UI affordance.
I think it would be fine to simply ignore it for now.
There was a problem hiding this comment.
didChangeStatus does not seem to be a LSP (the protocol) standard notification, it's copilot-specific.
From https://www.npmjs.com/package/@github/copilot-language-server :
Status Notification
The status is sent to the client as a didChangeStatus notification. Typically this would be conveyed to the user in a status bar icon or other UI affordance.
Notification includes the following fields:
message - a string describing the status (can be empty) kind - status of the language server: 'Normal' - When everything is working normally. 'Error' - When not authorized and authenticated. 'Warning' - When there is a temporary issue, such as a failed HTTP request. 'Inactive' - When the current file is ignored due to file size or content exclusions.
There was a problem hiding this comment.
We may want to handle this due to the Inactive kind -- it'd be good to know that a given file is not getting completions because of token limits ...
There was a problem hiding this comment.
New to emacs dev, but would you just want to print messages to the lsp log buffer when you get the inactive messages?
There was a problem hiding this comment.
mostly yes -- use lsp--info, --error, --warn -- that'll make to the lsp-mode log buffer and to the minibuffer, so the user has some visual feedback
|
Awesome! Official Announcement: https://github.blog/changelog/2025-02-10-copilot-language-server-sdk-is-now-available/ |
|
LGTM, thank you! |
About
Resolve #4708
Replace the LSP server used by the
lsp-copilotclient with the official GitHub one.https://www.npmjs.com/package/@github/copilot-language-server