Skip to content

fix: core was not recognized and 1-step lock did not work #4106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ckrenslehner
Copy link
Contributor

@ckrenslehner ckrenslehner commented Apr 17, 2025

The Core was not recognized properly, and the 1-step lock did not work, because the match was wrong.

@Dirbaio had the idea of using the build feature flags instead of reading the register for identifying the Core.
How would I specify such features for CM7 and CM4 for e.g. stm32h745?

@ckrenslehner ckrenslehner force-pushed the fix/hsem-implemention branch from c939306 to 3ee909b Compare April 17, 2025 13:23
@Dirbaio
Copy link
Member

Dirbaio commented Apr 17, 2025

you can add here another line

cfgs.push(format!("{}_{}", &chip_name[..chip_name.len() - 2], core));

like this

cfgs.push(format!("core_{}", core));

so you can do cfg(core_cm4)

@ckrenslehner ckrenslehner force-pushed the fix/hsem-implemention branch 2 times, most recently from a17e403 to e3034a7 Compare April 17, 2025 13:35
@ckrenslehner
Copy link
Contributor Author

Ok thanks I will add the cfgs

@Dirbaio
Copy link
Member

Dirbaio commented Apr 17, 2025

Have you seen #4092 ? seems you guys are working on the same thing.

@Dirbaio Dirbaio mentioned this pull request Apr 17, 2025
14 tasks
@ckrenslehner ckrenslehner force-pushed the fix/hsem-implemention branch 2 times, most recently from 7c8831c to bad3470 Compare April 19, 2025 08:31
@ckrenslehner ckrenslehner force-pushed the fix/hsem-implemention branch from bad3470 to 98339a6 Compare April 19, 2025 08:32
@ckrenslehner
Copy link
Contributor Author

I just updated this, as this is a stepping stone to #4116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants