[embassy-rp] Add disable and enable tx and rx functions for UART #4126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcemmers
force-pushed
the
uart-enable-disable-control
branch
from
d4fecbe to
e33dc09
Compare
marcemmers
changed the title
marcemmers
force-pushed
the
uart-enable-disable-control
branch
from
e33dc09 to
979eecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing some Modbus code on top of the RP2040 UART I encountered break and framing errors. I traced this back to the fact that my hardware pulls down the RX pin whenever I am transmitting data.
The UART peripheral has support for disabling RX or TX without influencing the other. It seemed like a good addition to make this available.
I thought about creating a type that freezes the UartRx or UartTx so you cannot have it disabled and try to receive or send respectively but could not figure it out since I am still learning rust.
Also, it is my first PR here so some guidance might be necessary, thanks for that!