Skip to content

add timer_src_clk_sys feature to support running RP2350x timer at s… #4157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

U007D
Copy link
Contributor

@U007D U007D commented May 2, 2025

…ystem clock frequency

NOTE:
@Dirbaio,

The changes seem to work. But I'm concerned that removing the tick-hz-1_000_000 from the time-driver feature may break existing users. What do you think?

I'll submit the MR, with this concern expressed in the description.

@U007D U007D force-pushed the support-rp235x-timer-source-clk_sys branch from b1eec4a to dc8e18c Compare May 2, 2025 19:06
@lulf
Copy link
Member

lulf commented May 9, 2025

…ystem clock frequency

NOTE: @Dirbaio,

The changes seem to work. But I'm concerned that removing the tick-hz-1_000_000 from the time-driver feature may break existing users. What do you think?

The default for not setting this feature is defined by the docs to be 1 mhz (https://docs.embassy.dev/embassy-time-driver/git/default/index.html#tick-rate), so I think this should be OK.

I'll submit the MR, with this concern expressed in the description.

@U007D U007D force-pushed the support-rp235x-timer-source-clk_sys branch 4 times, most recently from 96a0076 to c4ef628 Compare May 12, 2025 05:40
@U007D U007D force-pushed the support-rp235x-timer-source-clk_sys branch from c4ef628 to bbc5f3f Compare May 12, 2025 06:04
@U007D
Copy link
Contributor Author

U007D commented May 12, 2025

This MR now also properly sets the RP2350's TIMER0.SOURCE to CLK_SYS on init() when the timer-src-clk-sys feature is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants