embassy-rp: Make bit-depth of I2S PIO program configurable #4193
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PioI2sOutProgram
had a fixed 16bit sample depth, but that isn't reflected in the types name or the documentation.The
PioI2sOut
output driver on the other hand accepts abit_depth
argument.This was previously only used to calculate the clock frequency, while no other values than 16 made any sense.
This MR implements setting the sample bit-depth by setting it to scratch register
Y
, from where it is read by the PIO program.Also the channel argument is removed, since only 2 channels are supported.