Skip to content

GPDMA suspend channel before reset if already enabled #4981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xoviat merged 2 commits into from
Dec 5, 2025
Merged

GPDMA suspend channel before reset if already enabled #4981

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b732336
GPDMA suspend channel before reset if already enabled
usbalbin Dec 3, 2025
40d00d1
Add changelog
usbalbin Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions embassy-stm32/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## Unreleased - ReleaseDate

- fix: stm32: GPDMA driver reset ignored during channel configuration
- fix: stm32: SPI driver SSOE and SSM manegment, add `nss_output_disable` to SPI Config
- change: stm32: use typelevel timer type to allow dma for 32 bit timers
- fix: fix incorrect handling of split interrupts in timer driver
Expand Down
5 changes: 5 additions & 0 deletions embassy-stm32/src/dma/gpdma/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -238,6 +238,11 @@ impl AnyChannel {
// "Preceding reads and writes cannot be moved past subsequent writes."
fence(Ordering::SeqCst);

if ch.cr().read().en() {
ch.cr().modify(|w| w.set_susp(true));
while !ch.sr().read().suspf() {}
}

ch.cr().write(|w| w.set_reset(true));
ch.fcr().write(|w| {
// Clear all irqs
Expand Down