drop rsvp and fs-extra dependencies #393
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove RSVP dependency using same method as ember-bootstrap/ember-bootstrap#2055
jelhan
changed the title
jelhan
approved these changes
May 29, 2025
Chalk version 4.x was updated to 5.x in ember-bootstrap#325 but Chalk 5 makes breaking changes and can't be used in the same way: https://github.com/chalk/chalk/releases/tag/v5.0.0 Also added a test to run the blueprint, which catches the chalk version issue.
|
After running into issues using the blueprint, even with the currently published version, I fixed the issue and added a couple tests for the blueprint itself. I then could run the blueprint and verified it still worked with the blueprint fs changes (also the preprocessor test should now cover that too). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove RSVP dependency using same method as ember-bootstrap/ember-bootstrap#2055