-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a completely separate adapter for yarn #1026
Merged
bertdeblock
merged 2 commits into
ember-cli:main
from
bertdeblock:separate-yarn-adapter
Dec 13, 2024
Merged
Use a completely separate adapter for yarn #1026
bertdeblock
merged 2 commits into
ember-cli:main
from
bertdeblock:separate-yarn-adapter
Dec 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
==========================================
+ Coverage 94.96% 95.44% +0.48%
==========================================
Files 18 21 +3
Lines 556 505 -51
==========================================
- Hits 528 482 -46
+ Misses 28 23 -5 ☔ View full report in Codecov by Sentry. |
kategengler
reviewed
Dec 12, 2024
kategengler
reviewed
Dec 12, 2024
bertdeblock
force-pushed
the
separate-yarn-adapter
branch
from
December 12, 2024 19:43
b63eafc
to
3a74a76
Compare
bertdeblock
commented
Dec 12, 2024
bertdeblock
commented
Dec 12, 2024
kategengler
approved these changes
Dec 12, 2024
bertdeblock
force-pushed
the
separate-yarn-adapter
branch
from
December 13, 2024 09:22
3a74a76
to
c46951f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #1025.
This separates the yarn-specific logic from the npm-specific logic.
This also introduces a
BaseAdapter
class to get rid of duplication and ensure more consistency among adapters.