Don't use ember-cli project instance outside of ember-cli commands
#1036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1036 +/- ##
==========================================
+ Coverage 95.49% 95.54% +0.04%
==========================================
Files 21 21
Lines 511 516 +5
==========================================
+ Hits 488 493 +5
Misses 23 23 ☔ View full report in Codecov by Sentry. |
|
Still need to update getting the config without a |
kategengler
previously approved these changes
Dec 18, 2024
bertdeblock
force-pushed
the
dont-use-ember-cli-project-instance-outside-of-ember-cli-commands
branch
from
f747ca7 to
951a41e
Compare
bertdeblock
commented
Jan 20, 2025
| if (versionCompatibility) { | ||
| // Required lazily to improve startup speed. | ||
| let autoScenarioConfigForEmber = require('ember-try-config'); | ||
|
|
||
| let autoConfig = await autoScenarioConfigForEmber({ | ||
| versionCompatibility, | ||
| project: options.project, |
There was a problem hiding this comment.
Does not seem to be used by ember-try-config?
kategengler
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of decoupling
ember-tryfromember-cli.This way, only the code in
lib/commandsis coupled toember-cli.The next step would be to move the
runportion of the commands to separate files.This would allow us to move everything to ES modules, except the commands.
The commands can async import and run the ES modules.