Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete meetups that refer to discontinued groups #1090

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

jahrock
Copy link
Contributor

@jahrock jahrock commented Mar 8, 2024

Unfortunately, there are several discontinued meetup groups.

Of course, it would be nice if we could reactivate some of these groups. However, so that the active groups don't get lost in the crowd, I have removed the non-existent groups for the time being.

Copy link

netlify bot commented Mar 8, 2024

Deploy Preview for ember-website ready!

Name Link
🔨 Latest commit f71d463
🔍 Latest deploy log https://app.netlify.com/sites/ember-website/deploys/65ff2071bb16200008be1ab5
😎 Deploy Preview https://deploy-preview-1090--ember-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@NullVoxPopuli NullVoxPopuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be good to not mislead people as they browse this page.

Also, I'm not sure meetup is used much these days. Feels like I haven't had meetups marketed to me much since covid 🤷

Copy link
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you for the contribution! 🙌

EDIT: looks like there's a tiny lint issue. Could you run lint:js:fix?

@jahrock jahrock force-pushed the chore/meetup-cleanup branch from 5c084b8 to f71d463 Compare March 23, 2024 18:33
@IgnaceMaes IgnaceMaes merged commit 0ccadd7 into ember-learn:main Mar 23, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants